Fossil SCM

The click-to-diff feature of the graph doesn't work on IE8

Fixed

c650b0cd51170fe… · opened 13 years, 4 months ago

Type
Code_Defect
Priority
Severity
Minor
Resolution
Fixed
Subsystem
Created
Dec. 6, 2012 5:37 a.m.

On my IE8 in Windows 7 Pro, the new click to diff feature doesn't work. It works on Chrome though.

Comments (5)

altufaltu 13 years, 4 months ago

On my IE8 in Windows 7 Pro, the new click to diff feature doesn't work. It works on Chrome though.

drh 13 years, 4 months ago

The solution is to add some crazy-looking javascript to work around the non-compliant javascript implementation of IE8 and earlier. I am reluctant to add such hacks.

altufaltu 13 years, 4 months ago

OK. I was only worried that links removed by [89ab1185bf] should not heavily affect functionality for IE. I see that the Diffs: line will go away from checkin information page - minor one.

drh 13 years, 4 months ago

Possible solution: [http://stackoverflow.com/questions/10286162/pageyoffset-scrolling-and-animation-in-ie8]

altufaltu 13 years, 4 months ago

Works on IE8 now. Thanks for fix.

One suggestion: To mark version corresponding to second click (version to be diffed with) with a different color (although temporary) or change pointer to hourglass so that user knows that 2nd click was registered and diff is expected in few seconds.

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button