Fossil SCM

add %R prefix for /attachdownload and /attachview

Fixed

c899dd567b0dc87… · opened 11 years, 2 months ago

Type
Code_Defect
Priority
Severity
Minor
Resolution
Fixed
Subsystem
Created
Jan. 21, 2015 4:48 p.m.

Minor/cosmetic issue. (I've never really noticed prior discovering it in the new sitemap.) Live example on [http://fossil-scm.org/index.html/attachlist] :)

The /attachview and /attachdownload links in attachlist are absolute paths. Therefore they'll generate 404s on most public setups.

Another simple %R prefix in attach.c seems to work.

@ <br><a href="%R/attachview?%s(zUrlTail)">%h(zFilename)</a>
@ [<a href="%R/attachdownload/%t(zFilename)?%s(zUrlTail)">download</a>]<br />

Comments (2)

nobody 11 years, 2 months ago

Minor/cosmetic issue. (I've never really noticed prior discovering it in the new sitemap.) Live example on [http://fossil-scm.org/index.html/attachlist] :)

The /attachview and /attachdownload links in attachlist are absolute paths. Therefore they'll generate 404s on most public setups.

Another simple %R prefix in attach.c seems to work.

@ <br><a href="%R/attachview?%s(zUrlTail)">%h(zFilename)</a>
@ [<a href="%R/attachdownload/%t(zFilename)?%s(zUrlTail)">download</a>]<br />
drh 11 years, 2 months ago

Check-in [0438d06635892890f39f78995799539d25607e23]

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button