Fossil SCM
About a half of check-in link on timeline is not clickable
Fixed
ddd45723b9a214e…
· opened 16 years, 1 month ago
- Type
- Code_Defect
- Priority
- —
- Severity
- Cosmetic
- Resolution
- Fixed
- Subsystem
- —
- Created
- Feb. 16, 2010 10:24 a.m.
It may be due to canvas div
anonymous added on 2010-02-16 10:27:49:
windows
ff 3.5.7, opera 10.0
but in ie 8.0 it's OK
anonymous claiming to be anonymous pretending to be Darren Turland added on 2010-02-23 12:30:00:
The following patch will size the canvas div to the correct width.
Tested on ff 3.5.7, and ie8
--- src/timeline.c
+++ src/timeline.c
@@ -502,19 +502,19 @@
@ while( canvasDiv.hasChildNodes() ){
@ canvasDiv.removeChild(canvasDiv.firstChild);
@ }
@ var canvasY = absoluteY("canvas");
@ var left = absoluteX(rowinfo[0].id) - absoluteX("canvas") + 15;
- @ var width = left + nrail20 + 20;
+ @ var width = nrail20;
@ for(var i in rowinfo){
@ rowinfo[i].y = absoluteY(rowinfo[i].id) + 10 - canvasY;
@ rowinfo[i].x = left + rowinfo[i].r*20;
@ }
@ var btm = rowinfo[rowinfo.length-1].y + 20;
@ canvasDiv.innerHTML = '';
+ @ ' width="'+width+'" height="'+btm+'">';
@ realCanvas = document.getElementById('timeline-canvas');
@ var context;
@ if( realCanvas && realCanvas.getContext
@ && (context = realCanvas.getContext('2d'))) {
@ drawBox = function(color,x0,y0,x1,y1) {