Fossil SCM

Bug in blob_seek

Closed

e0ef6390ff5992f… · opened 15 years, 3 months ago

Type
Code_Defect
Priority
Immediate
Severity
Minor
Resolution
Overcome_By_Events
Subsystem
Created
Jan. 11, 2011 9:44 a.m.

The blob_seek function has the following

if( p->iCursor<0 ){
    p->iCursor = 0;
  }

But iCursor is an unsigned integer and will never go bellow 0, therefore this code does nothing. If iCursor is decremented past 0 it will go to a very high number.

I guess I'm being pedantic, but if you took the trouble to write the code I suppose you must have thought it important to guard against this.

Comments (1)

stephan 2 years, 2 months ago

The corresponding code has since disappeared.

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button