Fossil SCM

"zip.c" has two minor bugs.

Fixed

e28adcd72503a24… · opened 17 years, 4 months ago

Type
Code_Defect
Priority
Severity
Cosmetic
Resolution
Fixed
Subsystem
Created
Nov. 27, 2008 6:50 a.m.

"zip.c" has two minor bugs. 1. 'dosTime' time stamp has only 5 bits for 'seconds' field. so it requires devide by 2. (in function 'zip_set_timedate_from_str()')

-   dosTime = (H<<11) + (M<<5) + S;
+   dosTime = (H<<11) + (M<<5) + (S>>1);
2.  function 'baseline_zip_page()' (as 'WEBPAGE: zip') finally calls 'cgi_reply()', but it not required.

because 'cgi_reply()' calls by caller (main.c / process_one_web_page()) after this function returned. current version try to send '.zip' file twice. (almost http client checks 'Content-Length' header and shutdown themself first '.zip' file received. so this bug did not generate twice traffic.)


drh added on 2008-11-27 13:26:43:
Fixed by check-in [39bbc6010e]

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button