ScuttleBot
perf: remove SAMODE from GrantAccess — ChanServ AMODE only SAMODE through the topology IRC connection was competing with bridge messages and causing multi-second message send latency. ChanServ AMODE is persistent and sufficient.
Commit
fd949586a78e476d22c102bca82f311c58b3b98009b89bef089a58509a3194ad
Parent
c363d3dbd9eca65…
1 file changed
-6
| --- internal/topology/topology.go | ||
| +++ internal/topology/topology.go | ||
| @@ -298,18 +298,12 @@ | ||
| 298 | 298 | return |
| 299 | 299 | } |
| 300 | 300 | switch strings.ToUpper(level) { |
| 301 | 301 | case "OP": |
| 302 | 302 | m.chanserv("AMODE %s +o %s", channel, nick) |
| 303 | - if m.operPass != "" && m.client != nil { | |
| 304 | - m.client.Cmd.SendRawf("SAMODE %s +o %s", channel, nick) | |
| 305 | - } | |
| 306 | 303 | case "VOICE": |
| 307 | 304 | m.chanserv("AMODE %s +v %s", channel, nick) |
| 308 | - if m.operPass != "" && m.client != nil { | |
| 309 | - m.client.Cmd.SendRawf("SAMODE %s +v %s", channel, nick) | |
| 310 | - } | |
| 311 | 305 | default: |
| 312 | 306 | m.log.Warn("unknown access level", "level", level) |
| 313 | 307 | return |
| 314 | 308 | } |
| 315 | 309 | m.log.Info("granted channel access (AMODE)", "nick", nick, "channel", channel, "level", level) |
| 316 | 310 |
| --- internal/topology/topology.go | |
| +++ internal/topology/topology.go | |
| @@ -298,18 +298,12 @@ | |
| 298 | return |
| 299 | } |
| 300 | switch strings.ToUpper(level) { |
| 301 | case "OP": |
| 302 | m.chanserv("AMODE %s +o %s", channel, nick) |
| 303 | if m.operPass != "" && m.client != nil { |
| 304 | m.client.Cmd.SendRawf("SAMODE %s +o %s", channel, nick) |
| 305 | } |
| 306 | case "VOICE": |
| 307 | m.chanserv("AMODE %s +v %s", channel, nick) |
| 308 | if m.operPass != "" && m.client != nil { |
| 309 | m.client.Cmd.SendRawf("SAMODE %s +v %s", channel, nick) |
| 310 | } |
| 311 | default: |
| 312 | m.log.Warn("unknown access level", "level", level) |
| 313 | return |
| 314 | } |
| 315 | m.log.Info("granted channel access (AMODE)", "nick", nick, "channel", channel, "level", level) |
| 316 |
| --- internal/topology/topology.go | |
| +++ internal/topology/topology.go | |
| @@ -298,18 +298,12 @@ | |
| 298 | return |
| 299 | } |
| 300 | switch strings.ToUpper(level) { |
| 301 | case "OP": |
| 302 | m.chanserv("AMODE %s +o %s", channel, nick) |
| 303 | case "VOICE": |
| 304 | m.chanserv("AMODE %s +v %s", channel, nick) |
| 305 | default: |
| 306 | m.log.Warn("unknown access level", "level", level) |
| 307 | return |
| 308 | } |
| 309 | m.log.Info("granted channel access (AMODE)", "nick", nick, "channel", channel, "level", level) |
| 310 |