Fossil SCM

checkin/ef5424b683ad2830bfb111ea5756e00e3b8be5df5692ec95d28f1d851170c7c5

5 years, 5 months ago by wyoung

There are several non-obvious things about this commit.

The rules I used for picking the "page type" for each call to style_body_and_footer() are:

  1. Collect multi-page features under a single page type: e.g. all "forum" pages use the same type.

  2. All "test" type pages are type "test", no matter where they're served from, so you can do something type-specific with them, like give the page title a different color. If this is later considered a design error, one could change these instances to, e.g. "backlink test" for the case in backlink.c.

  3. Where there are multiple pages that don't compose a major user-facing feature, I sometimes used the name of the file where those pages are collected as the common type for pages served from that file. e.g. "cache"

Other points of interest:

  1. The implementation of proc styleFooter in TH1 should probably have an optional parameter added to pass along to style_body_and_footer() rather than hard-code "th1".

  2. Since none of these names are currently used for anything, they can all change until someone locks them down by making use of them. I plan only to use "forum" in a subsequent commit. Everything else is up in the air.

Keyboard Shortcuts

Open search /
Next entry (timeline) j
Previous entry (timeline) k
Open focused entry Enter
Show this help ?
Toggle theme Top nav button